Skip to content

EPD-2106: enable slack and github notifications for V2 - #374

Merged
josorio-autoblocks merged 3 commits into
mainfrom
jose/epd-2106-enable-slack-notifications
Jul 29, 2025
Merged

EPD-2106: enable slack and github notifications for V2#374
josorio-autoblocks merged 3 commits into
mainfrom
jose/epd-2106-enable-slack-notifications

Conversation

@josorio-autoblocks

@josorio-autoblocks josorio-autoblocks commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR implements Slack and GitHub notification support for the V2 testing framework in the Autoblocks Python SDK. The main changes include:

Core V2 Notification Functions: Two new functions are added to autoblocks/_impl/testing/v2/api.py:

  • send_v2_slack_notification(): Sends Slack notifications using app-scoped endpoints (/apps/{app_slug}/...)
  • send_v2_github_comment(): Posts GitHub comments with semaphore-based concurrency control

Both functions follow the same patterns as their V1 counterparts but use V2's app-scoped API architecture instead of direct endpoints.

Integration with Test Execution: The notification system is integrated into the V2 test runner (autoblocks/_impl/testing/v2/run.py) where notifications are dispatched after test completion using an all_settled pattern. This ensures notification failures don't impact test results while still attempting to deliver both Slack and GitHub notifications.

Conditional Logic: GitHub comments are only sent when a build_id is present (typically in CI environments), while Slack notifications are always attempted if properly configured. This matches the existing V1 behavior and integrates well with CI/CD workflows.

The implementation reuses utility functions and error handling patterns from the V1 codebase, maintaining consistency across the SDK while adapting to V2's architectural differences. The changes also include minor developer environment cleanup in .gitignore for Cursor IDE and Taskmaster tool configurations.

PR Description Notes:

  • The PR description is empty (null), which makes it difficult to understand the full context and requirements
  • There's a minor typo in .gitignore comment: "Curor" should be "Cursor"

Confidence score: 4/5

  • This PR is quite safe to merge with minimal risk of production issues
  • The implementation follows established patterns and includes proper error handling, but the empty PR description and minor inconsistencies slightly reduce confidence
  • The .gitignore file needs attention for the typo, and the empty PR description should be addressed for better documentation

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 4 comments

Edit Code Review Bot Settings | Greptile

Comment thread .gitignore Outdated
Comment thread autoblocks/_impl/testing/v2/api.py Outdated
Comment thread autoblocks/_impl/testing/v2/api.py Outdated
Comment thread autoblocks/_impl/testing/v2/run.py
@josorio-autoblocks
josorio-autoblocks merged commit 4380d1b into main Jul 29, 2025
6 checks passed
@josorio-autoblocks
josorio-autoblocks deleted the jose/epd-2106-enable-slack-notifications branch July 29, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant